Crate Shelf Tweaks #3560
Crate Shelf Tweaks #3560
Conversation
|
I’m actually not sure what this one accomplishes, ngl (also you didnt mention the maximum shelf count being, if i’m reading this right, 4). it seems like kind of a nothing change to me? |
They're on the Elated-Bolide and they look cool. |
|
Feels unnecessary and will make crate organization more of a PITA than it already is. Is there like, a reason it should be reduced? |
my bad on the max. that's fixed now. |
Shiptester reading comprehension at an all time low upon being forced to look at files changed (new max isn't at 4 as per 30 seconds ago) |
There was a problem hiding this comment.
This looks good though I would rather the default stay at 3 and var edit smaller ones where needed. Unless you looked through all of the existing maps that use them and really think its a good change.
There is also no validation in add_shelf that its in the legal limit.
Also define or var for max capacity please! Also a small message stating you cant build any higher, and one saying you need more then 1 sheet would be good feedback.
Possibly even how many more layers you can add to it in its examine text if your feeling spicy.
I think it's a fine change |
|
The do_after changes are done. I think having the default amount lower is Fine for a few reasons; |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Mapped crate shelves now start at a height of 2. You can build them to a max height of 4 Constructed crate shelves start at 1 crate and need to be built up You can now add shelves to crate shelves (with metal) <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game it's not, honestly. i think this change is going to be the death of the game. for pr after pr i've made nothing but hastily produced shitcode changes to a game that used to be soulful and thriving, stripping out the identity of what's made it so interesting to people. this is where it comes full circle. im sorry for doing this. but it had to be done. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: You can now add shelves to crate racks /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <[email protected]> Co-authored-by: Sun-Soaked <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Mapped crate shelves now start at a height of 2. You can build them to a max height of 4 Constructed crate shelves start at 1 crate and need to be built up You can now add shelves to crate shelves (with metal) <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game it's not, honestly. i think this change is going to be the death of the game. for pr after pr i've made nothing but hastily produced shitcode changes to a game that used to be soulful and thriving, stripping out the identity of what's made it so interesting to people. this is where it comes full circle. im sorry for doing this. but it had to be done. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: You can now add shelves to crate racks /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <[email protected]> Co-authored-by: Sun-Soaked <[email protected]>
About The Pull Request
Mapped crate shelves now start at a height of 3. You can build them to a max height of 4
Constructed crate shelves start at 1 crate and need to be built up
You can now add shelves to crate shelves (with metal)
Why It's Good For The Game
it's not, honestly. i think this change is going to be the death of the game. for pr after pr i've made nothing but hastily produced shitcode changes to a game that used to be soulful and thriving, stripping out the identity of what's made it so interesting to people. this is where it comes full circle. im sorry for doing this. but it had to be done.
Changelog
🆑
add: You can now add shelves to crate racks
/:cl: